Most profitable professions are considered to be Herbalism and Enchanting in pair. You can have Enchanting only for Disenchanting skill, it will bring decent gold. Consider the fact of disenchanting all soulbound armor, not just selling them to a vendor, but I do not recommend to disenchant any kind of weapons, it is more profitable to sell it to a merchant if it is a soulbound item, or sell it on auction house if it is BoE (bind on equip).
The simple truth behind all of this bickering and squabbling is that there really isn't a bad way to enjoy a game. You like the feeling of Classic taking you back to your young(er) days and that rush of falling in love with WoW for the first time? You like the slower pace of both combat and leveling? You like that the social aspects of the game take a front seat? Good, enjoy it! You prefer modern WoW and BfA with it's tons of improvements, smoother design and more player-friendly features? Great, enjoy it! It doesn't matter whether you prefer modern WoW or Classic or WotLK or whichever your personal high-point was (it was Burning Crusade and Legion for me), you're not wrong. You literally can't be. No matter what anyone says in all these heated discussions, they care about WoW, in whatever form they prefer it. So why can't this be enough of a commonality for us to have a civil discourse?